MEGAsquirt A place to collectively sort out this megasquirt gizmo

Closed loop ebc for MS3

Thread Tools
 
Search this Thread
 
Old 09-18-2013 | 07:16 PM
  #1  
Amellrotts's Avatar
Thread Starter
Senior Member
iTrader: (2)
 
Joined: Oct 2011
Posts: 675
Total Cats: 9
From: Hickory, NC
Question Closed loop ebc for MS3

I have read the thread on EBC but it was not clear what changes were made for MS3. Ken said in one of the posts that he changed the code for MS3 and the theory for tuning the EBC was different.

Can someone please explain what PID does and give me a starting point? I am looking for 18psi.

Thank you!
Old 09-18-2013 | 07:18 PM
  #2  
18psi's Avatar
VladiTuned
iTrader: (76)
 
Joined: Apr 2008
Posts: 35,821
Total Cats: 3,481
Default

You have found me. I am 18psi

You're welcome
Old 09-18-2013 | 07:18 PM
  #3  
aaronc7's Avatar
Senior Member
iTrader: (8)
 
Joined: Jun 2010
Posts: 1,116
Total Cats: 43
From: Florida
Default

Boost Control
Old 09-18-2013 | 07:20 PM
  #4  
18psi's Avatar
VladiTuned
iTrader: (76)
 
Joined: Apr 2008
Posts: 35,821
Total Cats: 3,481
Default

oh wow that's perfect.

+props

That's what I was trying to explain to you yesterday all written out and with pictures
Old 09-18-2013 | 07:23 PM
  #5  
aaronc7's Avatar
Senior Member
iTrader: (8)
 
Joined: Jun 2010
Posts: 1,116
Total Cats: 43
From: Florida
Default

Applies for latest MS2 firmware as well (what I used when I tuned my stuff up).
Old 09-18-2013 | 07:27 PM
  #6  
Amellrotts's Avatar
Thread Starter
Senior Member
iTrader: (2)
 
Joined: Oct 2011
Posts: 675
Total Cats: 9
From: Hickory, NC
Default

yeah, The other **** people were linking to on DIY website was the old MS2 stuff and I was afraid to use it. Thanks Aaron! That should be exactly what I needed!
Old 09-18-2013 | 07:42 PM
  #7  
JasonC SBB's Avatar
Elite Member
 
Joined: Jul 2005
Posts: 6,420
Total Cats: 84
Default

Closed loop fuel requires 3 things:

- a 12x12 or so table of AFR targets vs RPM and MAP
- an open loop 12x12 table of injector on-times vs RPM and MAP (the VE table)
- and the O2 sensor and PID to provide feedback to trim the AFR

Why doesn't boost control do the same thing?:

- an 8x8 table of boost target vs RPM and TPS
- an 8x8 table of open loop table of boost solenoid duty cycle vs. RPM and target boost
- and PID to provide feedback to trim the boost solenoid duty


And then just like fuel auto-tune changes the VE table, boost autotune should do the same for the open-loop duty table.

Last edited by JasonC SBB; 09-18-2013 at 09:47 PM.
Reply
Leave a poscat -1 Leave a negcat
Old 09-18-2013 | 07:46 PM
  #8  
stefanst's Avatar
Senior Member
iTrader: (1)
 
Joined: Sep 2011
Posts: 1,215
Total Cats: 74
From: Lambertville, NJ
Default

Originally Posted by JasonC SBB
Closed loop fuel requires 3 things:

- a 12x12 or so table of AFR targets vs RPM and MAP
- an open loop 12x12 table of injector on-times vs RPM and MAP
- and the O2 sensor and PID to provide feedback to trim the AFR

Why doesn't boost control do the same thing?:

- an 8x8 table of boost target vs RPM and TPS
- an 8x8 table of open loop table of boost solenoid duty cycle vs. RPM and target boost
- and PID to provide feedback to trim the boost solenoid duty
Ooooh, ooooh, ooooh. I'd love that!
Old 09-18-2013 | 09:30 PM
  #9  
JasonC SBB's Avatar
Elite Member
 
Joined: Jul 2005
Posts: 6,420
Total Cats: 84
Default

And then just like fuel auto-tune changes the VE table, boost autotune should do the same for the open-loop duty table.
Old 09-18-2013 | 10:35 PM
  #10  
Ben's Avatar
Ben
Supporting Vendor
iTrader: (33)
 
Joined: Jul 2006
Posts: 12,659
Total Cats: 134
From: atlanta-ish
Default

I generally welcome and enjoy your contributions Jason, but this one is making me wonder if you've ever actually used or tuned a MS3?

MS3 has several options for boost control:
-Standard open loop
-Closed loop with 8x8 boost target table
-Feed forward closed loop with 8x8 initial duty % table and 8x8 boost target table

Other algorithms exist to augment/supplement boost control as well, such as boost vs time after launch, boost vs VSS, boost vs gear, and a couple traction control strategies -- but I think these can be ignored for this conversation.

I think if you tried one of our closed loop strategies, you will find that the MS3 does an excellent job of closed loop control, and the "autotune" feature has potential to be a very dangerous solution to a problem that doesn't exist.


Originally Posted by JasonC SBB
Closed loop fuel requires 3 things:

- a 12x12 or so table of AFR targets vs RPM and MAP
- an open loop 12x12 table of injector on-times vs RPM and MAP (the VE table)
- and the O2 sensor and PID to provide feedback to trim the AFR

Why doesn't boost control do the same thing?:

- an 8x8 table of boost target vs RPM and TPS
- an 8x8 table of open loop table of boost solenoid duty cycle vs. RPM and target boost
- and PID to provide feedback to trim the boost solenoid duty


And then just like fuel auto-tune changes the VE table, boost autotune should do the same for the open-loop duty table.
__________________
Chief of Floor Sweeping, DIYAutoTune.com & AMP EFI
Crew Chief, Car Owner & Least Valuable Driver, HongNorrthRacing

91 Turbo | 10AE Turbo | 01 Track Rat | #323 Mazda Champcar

Originally Posted by concealer404
Buy an MSPNP Pro, you'll feel better.
Old 09-19-2013 | 02:19 AM
  #11  
JasonC SBB's Avatar
Elite Member
 
Joined: Jul 2005
Posts: 6,420
Total Cats: 84
Default

I'd be curious to see datalogs of results, duty cycle, boost and boost target... flooring it at different RPMs, from different starting values of MAP.
Old 09-19-2013 | 03:08 AM
  #12  
Zaphod's Avatar
Elite Member
 
Joined: Mar 2006
Posts: 1,559
Total Cats: 105
From: Schwarzenberg, Germany
Default

O.K. Jason, here you go.

Nr. 1
stomp on the throttle keeping it at 100%
4. Gear



Nr. 2
lighter throttle,
6. gear



Pretty darn good, I would say...
Attached Thumbnails Closed loop ebc for MS3-boost_1.jpg   Closed loop ebc for MS3-boost_2.jpg  
Old 09-19-2013 | 09:53 AM
  #13  
stefanst's Avatar
Senior Member
iTrader: (1)
 
Joined: Sep 2011
Posts: 1,215
Total Cats: 74
From: Lambertville, NJ
Default

I've looked and looked again and was unable to find the feed forward CL option. Is it in a newer FW release? I'm running one of the 1.2.x versions.
Old 09-19-2013 | 09:54 AM
  #14  
Braineack's Avatar
Boost Czar
iTrader: (62)
 
Joined: May 2005
Posts: 79,820
Total Cats: 4,152
From: Chantilly, VA
Default

I thought that was still in the alphas.
Old 09-19-2013 | 10:51 AM
  #15  
y8s's Avatar
y8s
DEI liberal femininity
iTrader: (8)
 
Joined: Jun 2005
Posts: 19,338
Total Cats: 574
From: Fake Virginia
Default

Zaphod: tune your enrichment and look under the file menu for "save graph as PNG". the world will be a better place!

I'm kinda sad I never got to play with the new method of boost.
Old 09-19-2013 | 10:56 AM
  #16  
Ben's Avatar
Ben
Supporting Vendor
iTrader: (33)
 
Joined: Jul 2006
Posts: 12,659
Total Cats: 134
From: atlanta-ish
Default

Originally Posted by stefanst
I've looked and looked again and was unable to find the feed forward CL option. Is it in a newer FW release? I'm running one of the 1.2.x versions.
The initial duty option is in the 1.3 chain, which is still considered alpha.
Downloadable here:
Megasquirt firmware downloads

This firmware also includes alternator control.
__________________
Chief of Floor Sweeping, DIYAutoTune.com & AMP EFI
Crew Chief, Car Owner & Least Valuable Driver, HongNorrthRacing

91 Turbo | 10AE Turbo | 01 Track Rat | #323 Mazda Champcar

Originally Posted by concealer404
Buy an MSPNP Pro, you'll feel better.
Old 09-19-2013 | 12:51 PM
  #17  
stefanst's Avatar
Senior Member
iTrader: (1)
 
Joined: Sep 2011
Posts: 1,215
Total Cats: 74
From: Lambertville, NJ
Default

And I thought I'd do some work on the house this weekend. Looks like I'll be installing FW and re-tuning instead :-)
Old 09-19-2013 | 01:56 PM
  #18  
JasonC SBB's Avatar
Elite Member
 
Joined: Jul 2005
Posts: 6,420
Total Cats: 84
Default

Zaphod,

Thanks. Do you have a log where you went WOT at high RPM, such as a WOT upshift?
Old 09-19-2013 | 02:14 PM
  #19  
Zaphod's Avatar
Elite Member
 
Joined: Mar 2006
Posts: 1,559
Total Cats: 105
From: Schwarzenberg, Germany
Default

Originally Posted by JasonC SBB
Zaphod,

Thanks. Do you have a log where you went WOT at high RPM, such as a WOT upshift?
I'll have a look.
Old 09-29-2013 | 12:44 PM
  #20  
JasonC SBB's Avatar
Elite Member
 
Joined: Jul 2005
Posts: 6,420
Total Cats: 84
Default

Here are mine:

Varying TPS ergo varying boost target. Note how it doesn't overshoot much and it hits the changing boost target quickly:



WOT'ing at different RPMs. Note how it hits full boost quickly with no overshoots even at different RPMs:



All times are GMT -4. The time now is 02:26 PM.